Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Electron] DCD fixes #1454

Merged
merged 2 commits into from Jan 15, 2018
Merged

[Electron] DCD fixes #1454

merged 2 commits into from Jan 15, 2018

Conversation

avtolstoy
Copy link
Member

@avtolstoy avtolstoy commented Dec 28, 2017

submission notes
**Important:** Please sanitize/remove any confidential info like usernames, passwords, org names, product names/ids, access tokens, client ids/secrets, or anything else you don't wish to share.

Please Read and Sign the Contributor License Agreement ([Info here](https://github.com/spark/firmware/blob/develop/CONTRIBUTING.md)).

You may also delete this submission notes header if you'd like. Thank you for contributing!

Problem

Despite introduction of #1295, Electrons sometimes still end up corrupting their DCD data (mainly keys).

Solution

This PR introduces a bugfix for a scenario where a valid secondary sector (marked with SEAL_INVALID_V2) is treated as invalid if primary is lost, causing DCD erasure.

This PR also introduces a couple of footer validations and fixes an issue during v1 -> v2 format upgrade, where the footer is not getting properly initialized, as well as fixes EC public key extraction/write procedure.

Steps to Test

  • unit tests

Example App

N/A

References


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@m-mcgowan
Copy link
Contributor

I will merge into develop, but I also feel perhaps that we should merge into 0.7.0 also.

@m-mcgowan m-mcgowan merged commit 84f89bf into develop Jan 15, 2018
@technobly
Copy link
Member

Agreed. Please do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants