Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
submission notes
Problem
Despite introduction of #1295, Electrons sometimes still end up corrupting their DCD data (mainly keys).
Solution
This PR introduces a bugfix for a scenario where a valid secondary sector (marked with
SEAL_INVALID_V2
) is treated as invalid if primary is lost, causing DCD erasure.This PR also introduces a couple of footer validations and fixes an issue during v1 -> v2 format upgrade, where the footer is not getting properly initialized, as well as fixes EC public key extraction/write procedure.
Steps to Test
Example App
N/A
References
Completeness